Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1491373005: VM: Fix bug in type propagation at conditionals. (Closed)

Created:
5 years ago by Florian Schneider
Modified:
5 years ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Fix bug in type propagation at conditionals. Propagating type/cid at conditional branches is not possible because it may cause invalid code motion. For this to be safe we need to explicitly represent the dependency between checks eliminated in a branch and the condition that constrains the type/cid. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/dff13bef8de104d33b04820136da2d80f3c835d7

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -58 lines) Patch
M runtime/vm/flow_graph_type_propagator.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 2 chunks +0 lines, -57 lines 0 comments Download
A tests/language/vm/type_propagation_test.dart View 1 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
5 years ago (2015-12-03 20:03:12 UTC) #2
Vyacheslav Egorov (Google)
lgtm
5 years ago (2015-12-03 20:07:07 UTC) #3
Florian Schneider
5 years ago (2015-12-03 20:14:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
dff13bef8de104d33b04820136da2d80f3c835d7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698