Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1491373003:
Use catapult gsutil instead of telemetry gsutilz. (Closed)
|
Created:
5 years ago by aiolos (Not reviewing) Modified:
5 years ago CC:
chromium-reviews, telemetry-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse catapult gsutil instead of telemetry gsutilz.
BUG=564919
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect
Committed: https://crrev.com/31ee1125bd9ca6b886da42cd20b8bef2415d084a
Cr-Commit-Position: refs/heads/master@{#363247}
Patch Set 1 : Actual changes #Patch Set 2 : add perf no-op for try jobs #
Total comments: 2
Patch Set 3 : Dave nit #
Dependent Patchsets: Messages
Total messages: 28 (15 generated)
Description was changed from ========== Use catapult gsutil instead of telemetry gsutilz. BUG=564919 ========== to ========== Use catapult gsutil instead of telemetry gsutilz. BUG=564919 ==========
aiolos@chromium.org changed reviewers: + eakuefner@chromium.org
I'll still need to update the gsutil in catapult.
Description was changed from ========== Use catapult gsutil instead of telemetry gsutilz. BUG=564919 ========== to ========== Use catapult gsutil instead of telemetry gsutilz. BUG=564919 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect ==========
The CQ bit was checked by aiolos@chromium.org to run a CQ dry run
Description was changed from ========== Use catapult gsutil instead of telemetry gsutilz. BUG=564919 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect ========== to ========== Use catapult gsutil instead of telemetry gsutilz. BUG=564919 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect ==========
aiolos@chromium.org changed reviewers: + dtu@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491373003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491373003/20001
lgtm nit https://codereview.chromium.org/1491373003/diff/20001/tools/telemetry/telemet... File tools/telemetry/telemetry/core/util.py (right): https://codereview.chromium.org/1491373003/diff/20001/tools/telemetry/telemet... tools/telemetry/telemetry/core/util.py:31: os.path.abspath(__file__), '..', '..', '..', 'third_party')) how about os.path.join(GetTelemetryDir(), 'third_party') ?
https://codereview.chromium.org/1491373003/diff/20001/tools/telemetry/telemet... File tools/telemetry/telemetry/core/util.py (right): https://codereview.chromium.org/1491373003/diff/20001/tools/telemetry/telemet... tools/telemetry/telemetry/core/util.py:31: os.path.abspath(__file__), '..', '..', '..', 'third_party')) On 2015/12/03 19:20:42, dtu wrote: > how about os.path.join(GetTelemetryDir(), 'third_party') ? Done.
mega lgtm
The CQ bit was checked by aiolos@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dtu@chromium.org Link to the patchset: https://codereview.chromium.org/1491373003/#ps40001 (title: "Dave nit")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491373003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491373003/40001
Description was changed from ========== Use catapult gsutil instead of telemetry gsutilz. BUG=564919 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect ========== to ========== Use catapult gsutil instead of telemetry gsutilz. BUG=564919 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect ==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
bisect timeout. Restarting cq.
The CQ bit was checked by aiolos@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491373003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491373003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) win_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by aiolos@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491373003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491373003/40001
Message was sent while issue was closed.
Description was changed from ========== Use catapult gsutil instead of telemetry gsutilz. BUG=564919 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect ========== to ========== Use catapult gsutil instead of telemetry gsutilz. BUG=564919 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Use catapult gsutil instead of telemetry gsutilz. BUG=564919 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect ========== to ========== Use catapult gsutil instead of telemetry gsutilz. BUG=564919 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect Committed: https://crrev.com/31ee1125bd9ca6b886da42cd20b8bef2415d084a Cr-Commit-Position: refs/heads/master@{#363247} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/31ee1125bd9ca6b886da42cd20b8bef2415d084a Cr-Commit-Position: refs/heads/master@{#363247} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
