Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Issue 149133005: Update callers of WebArrayBuffer/V8 conversions to use WebArrayBufferConverter (Closed)

Created:
6 years, 10 months ago by adamk
Modified:
6 years, 10 months ago
Reviewers:
jamesr
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, abarth-chromium, pilgrim_google
Visibility:
Public.

Description

Update callers of WebArrayBuffer/V8 conversions to use WebArrayBufferConverter This will allow moving WebArrayBuffer's implementation into Blink's platform dll. Depends on https://src.chromium.org/viewvc/blink?view=rev&revision=166514 BUG=297477 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249479

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M content/renderer/pepper/v8_var_converter.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/skia_benchmarking_extension.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/v8_value_converter_impl.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
adamk
6 years, 10 months ago (2014-02-05 20:46:34 UTC) #1
jamesr
lgtm
6 years, 10 months ago (2014-02-05 20:50:44 UTC) #2
adamk
The CQ bit was checked by adamk@chromium.org
6 years, 10 months ago (2014-02-06 17:56:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/149133005/1
6 years, 10 months ago (2014-02-06 17:57:17 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-06 20:10:40 UTC) #5
Message was sent while issue was closed.
Change committed as 249479

Powered by Google App Engine
This is Rietveld 408576698