Issue 149133005: Update callers of WebArrayBuffer/V8 conversions to use WebArrayBufferConverter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149133005: Update callers of WebArrayBuffer/V8 conversions to use WebArrayBufferConverter (Closed)

Created:
6 years, 10 months ago by adamk

Modified:
6 years, 10 months ago

Reviewers:
jamesr

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, abarth-chromium, pilgrim_google

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update callers of WebArrayBuffer/V8 conversions to use WebArrayBufferConverter This will allow moving WebArrayBuffer's implementation into Blink's platform dll. Depends on https://src.chromium.org/viewvc/blink?view=rev&revision=166514 BUG=297477 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249479

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -5 lines)			Patch
M	content/renderer/pepper/v8_var_converter.cc	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	content/renderer/skia_benchmarking_extension.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	content/renderer/v8_value_converter_impl.cc	View	3 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/149133005/1

6 years, 10 months ago (2014-02-06 17:57:17 UTC) #4

Message was sent while issue was closed.

Change committed as 249479

Expand Messages | Collapse Messages