Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1491283002: VM: Fix crash in profile signal handler. (Closed)

Created:
5 years ago by Florian Schneider
Modified:
5 years ago
Reviewers:
siva, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Fix crash in profile signal handler. The profile signal handler may interrupt when the current Thread is in an inconsistent state. Members of the Thread that is unscheduled are NULLed out before OSThread::SetCurrent sets a new current Thread. Fix this by resetting the current Thread's fields after a new Thread is set as current. BUG=#25072 R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/d9b13018218c19c82e86c8da6020bdc524fef7de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/thread_registry.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Florian Schneider
5 years ago (2015-12-02 17:16:32 UTC) #2
Ivan Posva
LGTM -ip
5 years ago (2015-12-03 20:55:53 UTC) #4
Florian Schneider
Committed patchset #1 (id:1) manually as d9b13018218c19c82e86c8da6020bdc524fef7de (presubmit successful).
5 years ago (2015-12-03 21:00:29 UTC) #6
siva
LGTM. Thanks for taking care of this. Was this the cause of the google3 crash ...
5 years ago (2015-12-14 16:23:00 UTC) #7
Florian Schneider
5 years ago (2015-12-14 16:31:19 UTC) #8
Message was sent while issue was closed. 
On 2015/12/14 16:23:00, siva wrote:
> LGTM. Thanks for taking care of this.
> 
> Was this the cause of the google3 crash that Dan reported in a different
email.

No, this was a flaky crash observed on the buildbot. Oh the issue number is
#25072 btw. - I mistyped it.

The other crash was a bug in the optimizer which led to incorrect optimized
code.

Powered by Google App Engine
This is Rietveld 408576698