Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1491263002: Revert of Fixes document type detection on iOS 9. (Closed)

Created:
5 years ago by bzanotti
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Revert of Fixes document type detection on iOS 9. (patchset #1 id:1 of https://codereview.chromium.org/1491043004/ ) Reason for revert: No approval for this cherry-pick. Reverting. Original issue's description: > Fixes document type detection on iOS 9. > > On iOS 9, evaluating '' + document always results in [object > HTMLDocument], even for PDFs. This introduces another way of checking > document type on iOS 9. Unfortunately, it doesn't work on iOS 8, so the > old implementation needs to stay too. > > BUG=549604 > > Review URL: https://codereview.chromium.org/1458703004 > > Cr-Commit-Position: refs/heads/master@{#361095} > (cherry picked from commit 704def3b29d00bf39aca6553a079152171af4ad9) > > Committed: https://chromium.googlesource.com/chromium/src/+/f5f194b3efbdfc92886eebe0b359a25518061fe0 TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=549604

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -39 lines) Patch
M ios/web/web_state/ui/crw_ui_web_view_web_controller.mm View 2 chunks +7 lines, -20 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +0 lines, -14 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller+protected.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_web_view_web_controller.mm View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bzanotti
Created Revert of Fixes document type detection on iOS 9.
5 years ago (2015-12-02 16:43:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491263002/1
5 years ago (2015-12-02 16:43:55 UTC) #2
commit-bot: I haz the power
5 years ago (2015-12-02 16:45:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698