Chromium Code Reviews| Index: third_party/WebKit/Source/platform/heap/Handle.h |
| diff --git a/third_party/WebKit/Source/platform/heap/Handle.h b/third_party/WebKit/Source/platform/heap/Handle.h |
| index 9ef17dedb23ab35406e19a1e1e774f52269c40af..e0332b2ae08ff401397b1ab2489d81c2e3cb91b7 100644 |
| --- a/third_party/WebKit/Source/platform/heap/Handle.h |
| +++ b/third_party/WebKit/Source/platform/heap/Handle.h |
| @@ -46,6 +46,10 @@ |
| #include "wtf/RefCounted.h" |
| #include "wtf/TypeTraits.h" |
| +#if defined(LEAK_SANITIZER) |
| +#include "wtf/LeakAnnotations.h" |
| +#endif |
| + |
| namespace blink { |
| enum WeaknessPersistentConfiguration { |
| @@ -183,6 +187,16 @@ public: |
| return *this; |
| } |
| +#if defined(LEAK_SANITIZER) |
| + PersistentBase* registerAsStaticReference() |
| + { |
| + if (m_persistentNode) { |
| + ThreadState::current()->registerStaticPersistentNode(m_persistentNode); |
|
haraken
2015/12/07 14:46:10
Add ASSERT(ThreadState::current()).
sof
2015/12/07 16:59:17
Done.
|
| + LEAK_SANITIZER_IGNORE_OBJECT(this); |
| + } |
| + return this; |
| + } |
| +#endif |
| private: |
| NO_LAZY_SWEEP_SANITIZE_ADDRESS |
| @@ -545,7 +559,19 @@ public: |
| visitor->trace(*static_cast<Collection*>(this)); |
| } |
| +#if defined(LEAK_SANITIZER) |
| + PersistentHeapCollectionBase* registerAsStaticReference() |
| + { |
| + if (m_persistentNode) { |
| + ThreadState::current()->registerStaticPersistentNode(m_persistentNode); |
|
haraken
2015/12/07 14:46:10
Ditto.
|
| + LEAK_SANITIZER_IGNORE_OBJECT(this); |
| + } |
| + return this; |
| + } |
| +#endif |
| + |
| private: |
| + |
| NO_LAZY_SWEEP_SANITIZE_ADDRESS |
| void initialize() |
| { |
| @@ -1067,7 +1093,7 @@ template<typename T> T* adoptPtrWillBeNoop(T* ptr) |
| #define DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(type) // do nothing |
| #define DEFINE_STATIC_REF_WILL_BE_PERSISTENT(type, name, arguments) \ |
| - static type* name = (new Persistent<type>(arguments))->get(); |
| + static type* name = *(new Persistent<type>(arguments))->registerAsStaticReference(); |
| #else // !ENABLE(OILPAN) |
| @@ -1266,6 +1292,34 @@ private: |
| CrossThreadWeakPersistent<T> m_value; |
| }; |
| +// LEAK_SANITIZER_DISABLED_SCOPE: all allocations made in the current scope |
| +// will be exempted from LSan consideration. |
| +// |
| +// TODO(sof): move this to wtf/LeakAnnotations.h (LeakSanitizer.h?) once |
| +// wtf/ can freely call upon Oilpan functionality. |
| +#if defined(LEAK_SANITIZER) |
| +class LeakSanitizerDisableScope { |
|
haraken
2015/12/07 14:46:10
Add STACK_ALLOCATED.
sof
2015/12/07 16:59:17
Done.
|
| + WTF_MAKE_NONCOPYABLE(LeakSanitizerDisableScope); |
| +public: |
| + LeakSanitizerDisableScope() |
| + { |
| + __lsan_disable(); |
| + if (ThreadState::current()) |
| + ThreadState::current()->enterStaticReferenceRegistrationDisabledScope(); |
| + } |
| + |
| + ~LeakSanitizerDisableScope() |
| + { |
| + __lsan_enable(); |
| + if (ThreadState::current()) |
| + ThreadState::current()->leaveStaticReferenceRegistrationDisabledScope(); |
| + } |
| +}; |
| +#define LEAK_SANITIZER_DISABLED_SCOPE LeakSanitizerDisableScope lsanDisabledScope |
| +#else |
| +#define LEAK_SANITIZER_DISABLED_SCOPE |
| +#endif |
| + |
| } // namespace blink |
| namespace WTF { |