Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: content/common/gpu/client/gl_helper_unittest.cc

Issue 149123008: Implement GLHelperReadbackSupport for GLHelper usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Formatted cl using git format option. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/client/gl_helper_unittest.cc
diff --git a/content/common/gpu/client/gl_helper_unittest.cc b/content/common/gpu/client/gl_helper_unittest.cc
index 91cfa2179f5261cb855609e567c514b9ed93d9bf..1cb10590188d109f953b35b1ef04cf9dfa6206e6 100644
--- a/content/common/gpu/client/gl_helper_unittest.cc
+++ b/content/common/gpu/client/gl_helper_unittest.cc
@@ -1001,12 +1001,9 @@ class GLHelperTest : public testing::Test {
bool TestTextureFormatReadback(const gfx::Size& src_size,
SkBitmap::Config bitmap_config,
bool async) {
- DCHECK((bitmap_config == SkBitmap::kRGB_565_Config) ||
- (bitmap_config == SkBitmap::kARGB_8888_Config));
- bool rgb565_format = (bitmap_config == SkBitmap::kRGB_565_Config);
- if (rgb565_format && !helper_->CanUseRgb565Readback()) {
- LOG(INFO) << "RGB565 Format Not supported on this platform";
- LOG(INFO) << "Skipping RGB565ReadBackTest";
+ if (!helper_->IsReadBackConfigSupported(bitmap_config)) {
+ LOG(INFO) << "Format Not supported on this platform" << bitmap_config
+ << "Skipping the test";
no sievers 2014/02/19 19:09:39 nit: does this need to be spaced? something like
sivag 2014/02/21 11:40:51 Done.
return true;
}
WebGLId src_texture = context_->createTexture();
« content/common/gpu/client/gl_helper.cc ('K') | « content/common/gpu/client/gl_helper.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698