 Chromium Code Reviews
 Chromium Code Reviews Issue 149123008:
  Implement GLHelperReadbackSupport for GLHelper usage.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 149123008:
  Implement GLHelperReadbackSupport for GLHelper usage.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: content/common/gpu/client/gl_helper_unittest.cc | 
| diff --git a/content/common/gpu/client/gl_helper_unittest.cc b/content/common/gpu/client/gl_helper_unittest.cc | 
| index 91cfa2179f5261cb855609e567c514b9ed93d9bf..bef4dc03a731712ea722e98f864c5c64975d6515 100644 | 
| --- a/content/common/gpu/client/gl_helper_unittest.cc | 
| +++ b/content/common/gpu/client/gl_helper_unittest.cc | 
| @@ -1001,12 +1001,9 @@ class GLHelperTest : public testing::Test { | 
| bool TestTextureFormatReadback(const gfx::Size& src_size, | 
| SkBitmap::Config bitmap_config, | 
| bool async) { | 
| - DCHECK((bitmap_config == SkBitmap::kRGB_565_Config) || | 
| - (bitmap_config == SkBitmap::kARGB_8888_Config)); | 
| - bool rgb565_format = (bitmap_config == SkBitmap::kRGB_565_Config); | 
| - if (rgb565_format && !helper_->CanUseRgb565Readback()) { | 
| - LOG(INFO) << "RGB565 Format Not supported on this platform"; | 
| - LOG(INFO) << "Skipping RGB565ReadBackTest"; | 
| + if (!helper_->IsReadBackConfigSupported(bitmap_config)) { | 
| + LOG(INFO) << "Format Not supported on this platform"<<bitmap_config ; | 
| 
no sievers
2014/02/18 19:35:44
nit: formatting
You might want to look at ClangFo
 
sivag
2014/02/19 15:49:04
Done.
 | 
| + LOG(INFO) << "Skipping the test"; | 
| 
no sievers
2014/02/18 19:35:44
nit: can be written as one stream with the above
 
sivag
2014/02/19 15:49:04
Done.
 | 
| return true; | 
| } | 
| WebGLId src_texture = context_->createTexture(); |