src/runtime.cc - Issue 14912002: toString() on generator functions prints with function*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 14912002: toString() on generator functions prints with function* (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Remove TODO Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index 8cd2de21b6c7513752456a06b374a8246cc4cb8e..0fcdb457c1c62ef6595313e586ffe06c118e88d3 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -2189,6 +2189,14 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_FunctionMarkNameShouldPrintAsAnonymous) {

}

+RUNTIME_FUNCTION(MaybeObject*, Runtime_FunctionIsGenerator) {

+ NoHandleAllocation ha(isolate);

+ ASSERT(args.length() == 1);

+ CONVERT_ARG_CHECKED(JSFunction, f, 0);

+ return isolate->heap()->ToBoolean(f->shared()->is_generator());

RUNTIME_FUNCTION(MaybeObject*, Runtime_FunctionRemovePrototype) {

NoHandleAllocation ha(isolate);

ASSERT(args.length() == 1);

« no previous file with comments | « src/runtime.h ('k') | src/v8natives.js » ('j') | no next file with comments »