Issue 14912002: toString() on generator functions prints with function*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14912002: toString() on generator functions prints with function* (Closed)

Created:
7 years, 7 months ago by wingo

Modified:
7 years, 7 months ago

Reviewers:
Michael Starzinger

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

More Reviews

Description

toString() on generator functions prints with function* This CL adds a %FunctionIsGenerator runtime function, and uses it in the function toString() implementation. R=mstarzinger@chromium.org BUG=v8:2355 TEST=mjsunit/harmony/generators-runtime Committed: 14544

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove TODO #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
M	src/runtime.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/v8natives.js	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/mjsunit/harmony/generators-runtime.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM if one nit is addressed. https://codereview.chromium.org/14912002/diff/1/src/v8natives.js File src/v8natives.js (right): https://codereview.chromium.org/14912002/diff/1/src/v8natives.js#newcode1668 src/v8natives.js:1668: // TODO(wingo): Print ...

7 years, 7 months ago (2013-05-03 10:35:08 UTC) #2

wingo

7 years, 7 months ago (2013-05-03 13:01:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r14544 (presubmit successful).

Expand Messages | Collapse Messages