third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp - Issue 1491193003: Fix several corner case issues of scrollbar paint invalidation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 1491193003: Fix several corner case issues of scrollbar paint invalidation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp ('K') | « third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp ('k') | third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

index be14a49bac2335e64a9906bd770e713673683571..aaaab5d09e71a2a35992996d6ba1fe345e8ba0c6 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

@@ -676,9 +676,6 @@ void PaintLayerScrollableArea::finalizeScrollDimensions(const DoubleSize& origin

m_inOverflowRelayout = true;

SubtreeLayoutScope layoutScope(box());

layoutScope.setNeedsLayout(&box(), LayoutInvalidationReason::ScrollbarChanged);

- // TODO(wangxianzhu): Remove the following statement when paint invalidation

- // can detect client box changes. crbug.com/560418.

- box().setShouldDoFullPaintInvalidation();

if (box().isLayoutBlock()) {

LayoutBlock& block = toLayoutBlock(box());

block.scrollbarsChanged(autoHorizontalScrollBarChanged, autoVerticalScrollBarChanged);