third_party/WebKit/Source/core/layout/LayoutObject.cpp - Issue 1491193003: Fix several corner case issues of scrollbar paint invalidation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 1491193003: Fix several corner case issues of scrollbar paint invalidation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/repaint/overflow-scroll-body-appear-expected.txt ('k') | third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp » ('j') | third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

index 21e6e9cd7f463c54dd4d7ea778c4bf3770bf49ad..92d305b7845e4b01c510175c60482ab9bc28ebc2 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

@@ -3408,6 +3408,10 @@ void LayoutObject::invalidatePaintOfPreviousPaintInvalidationRect(const LayoutBo

// under-invalidation if the new paint invalidation rect on the new paint invalidation container

// happens to be the same as the old one.

setPreviousPaintInvalidationRect(LayoutRect());

+ if (isBox()) {

+ if (PaintLayerScrollableArea* scrollableArea = toLayoutBox(this)->scrollableArea())

+ scrollableArea->clearPreviousPaintInvalidationRects();

+ }

}

void LayoutObject::invalidatePaintIncludingNonCompositingDescendants()