third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp - Issue 1491193003: Fix several corner case issues of scrollbar paint invalidation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

Issue 1491193003: Fix several corner case issues of scrollbar paint invalidation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp b/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

index b3bb5511694b3d2035c40d8b161464fde62481ca..b55416e2436510b59648d9601cbd723d6e4a0b17 100644

--- a/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

@@ -333,11 +333,11 @@ void PaintLayerCompositor::updateWithoutAcceleratedCompositing(CompositingUpdate

static void forceRecomputePaintInvalidationRectsIncludingNonCompositingDescendants(LayoutObject* layoutObject)

{

- // We clear the previous paint invalidation rect as it's wrong (paint invaliation container

+ // We clear the previous paint invalidation rect as it's wrong (paint invalidation container

// changed, ...). Forcing a full invalidation will make us recompute it. Also we are not

// changing the previous position from our paint invalidation container, which is fine as

// we want a full paint invalidation anyway.

- layoutObject->setPreviousPaintInvalidationRect(LayoutRect());

+ layoutObject->clearPreviousPaintInvalidationRects();

layoutObject->setShouldDoFullPaintInvalidation();

for (LayoutObject* child = layoutObject->slowFirstChild(); child; child = child->nextSibling()) {