Call pseudoStateChangedForElement from Element::pseudoStateChanged only.

Call pseudoStateChangedForElement from Element::pseudoStateChanged only.

There were a few places where StyleEngine::pseudoStateChangedForElement
was called directly instead of via Element::pseudoStateChanged. Changed
to have consistently common code paths.

Committed: https://crrev.com/7ea4ad75aa326b94128146491dc544c92d347a30
Cr-Commit-Position: refs/heads/master@{#363177}

[rune, 2015-12-03 23:37:43]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-03 23:40:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1491183007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1491183007/1

[commit-bot: I haz the power, 2015-12-04 01:45:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 01:45:19]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  android_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  cast_shell_android on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  cast_shell_linux on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_android_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[rune, 2015-12-04 09:16:38]

rune@opera.com changed reviewers:
+ mstensho@opera.com

[mstensho (USE GERRIT), 2015-12-04 09:28:12]

lgtm, with some nits on the commit comment:

> Call pseudoStateChangedForElement  from Element::pseudoStateChanged only.

Double space.

> There were a few places where StyleEngine::pseudoStateChangedForElement
> were called directly instead of via Element::pseudoStateChanged. Changed

*was* called

[rune, 2015-12-04 09:30:39]

Description was changed from

==========
Call pseudoStateChangedForElement  from Element::pseudoStateChanged only.

There were a few places where StyleEngine::pseudoStateChangedForElement
were called directly instead of via Element::pseudoStateChanged. Changed
to have consistently common code paths.
==========

to

==========
Call pseudoStateChangedForElement from Element::pseudoStateChanged only.

There were a few places where StyleEngine::pseudoStateChangedForElement
was called directly instead of via Element::pseudoStateChanged. Changed
to have consistently common code paths.
==========

[rune, 2015-12-04 09:31:06]

On 2015/12/04 09:28:12, mstensho wrote:
> lgtm, with some nits on the commit comment:
> 
> > Call pseudoStateChangedForElement  from Element::pseudoStateChanged only.
> 
> Double space.

Done.

> > There were a few places where StyleEngine::pseudoStateChangedForElement
> > were called directly instead of via Element::pseudoStateChanged. Changed
> 
> *was* called

Done.

[rune, 2015-12-04 09:31:09]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2015-12-04 09:32:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1491183007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1491183007/1

[commit-bot: I haz the power, 2015-12-04 09:37:59]

Description was changed from

==========
Call pseudoStateChangedForElement from Element::pseudoStateChanged only.

There were a few places where StyleEngine::pseudoStateChangedForElement
was called directly instead of via Element::pseudoStateChanged. Changed
to have consistently common code paths.
==========

to

==========
Call pseudoStateChangedForElement from Element::pseudoStateChanged only.

There were a few places where StyleEngine::pseudoStateChangedForElement
was called directly instead of via Element::pseudoStateChanged. Changed
to have consistently common code paths.
==========

[commit-bot: I haz the power, 2015-12-04 09:38:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-04 09:39:54]

Description was changed from

==========
Call pseudoStateChangedForElement from Element::pseudoStateChanged only.

There were a few places where StyleEngine::pseudoStateChangedForElement
was called directly instead of via Element::pseudoStateChanged. Changed
to have consistently common code paths.
==========

to

==========
Call pseudoStateChangedForElement from Element::pseudoStateChanged only.

There were a few places where StyleEngine::pseudoStateChangedForElement
was called directly instead of via Element::pseudoStateChanged. Changed
to have consistently common code paths.

Committed: https://crrev.com/7ea4ad75aa326b94128146491dc544c92d347a30
Cr-Commit-Position: refs/heads/master@{#363177}
==========

[commit-bot: I haz the power, 2015-12-04 09:39:54]

Patchset 1 (id:??) landed as
https://crrev.com/7ea4ad75aa326b94128146491dc544c92d347a30
Cr-Commit-Position: refs/heads/master@{#363177}