Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Unified Diff: tools/telemetry/telemetry/page/shared_page_state_unittest.py

Issue 1491183003: [Telemetry] Move WPR life cycle from browser to platform (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: work in progress Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/shared_page_state_unittest.py
diff --git a/tools/telemetry/telemetry/page/shared_page_state_unittest.py b/tools/telemetry/telemetry/page/shared_page_state_unittest.py
index c6b5e3e3044e47a91e889e15131db9eb8d5e169b..bb04971096939805a8679423818cd64b2c3cf7a3 100644
--- a/tools/telemetry/telemetry/page/shared_page_state_unittest.py
+++ b/tools/telemetry/telemetry/page/shared_page_state_unittest.py
@@ -27,19 +27,6 @@ class DummyTest(page_test.PageTest):
pass
-class FakeNetworkController(object):
-
- def __init__(self):
- self.archive_path = None
- self.wpr_mode = None
-
- def SetReplayArgs(self, archive_path, wpr_mode, netsim, extra_wpr_args,
- make_javascript_deterministic=False):
- del netsim, extra_wpr_args, make_javascript_deterministic # unused
- self.archive_path = archive_path
- self.wpr_mode = wpr_mode
-
-
class SharedPageStateTests(unittest.TestCase):
def setUp(self):
@@ -48,21 +35,18 @@ class SharedPageStateTests(unittest.TestCase):
self.options.output_formats = ['none']
self.options.suppress_gtest_report = True
- def TestUseLiveSitesFlag(self, expected_wpr_mode):
- with tempfile.NamedTemporaryFile() as f:
- run_state = shared_page_state.SharedPageState(
- DummyTest(), self.options, story_module.StorySet())
- fake_network_controller = FakeNetworkController()
- run_state._PrepareWpr(fake_network_controller, f.name, None)
- self.assertEquals(fake_network_controller.wpr_mode, expected_wpr_mode)
- self.assertEquals(fake_network_controller.archive_path, f.name)
+ def _TestUseLiveSitesFlag(self, expected_wpr_mode):
+ run_state = shared_page_state.SharedPageState(
+ DummyTest(), self.options, story_module.StorySet())
+ self.assertEquals(run_state.platform.network_controller.wpr_mode,
+ expected_wpr_mode)
def testUseLiveSitesFlagSet(self):
self.options.use_live_sites = True
- self.TestUseLiveSitesFlag(expected_wpr_mode=wpr_modes.WPR_OFF)
+ self._TestUseLiveSitesFlag(expected_wpr_mode=wpr_modes.WPR_OFF)
def testUseLiveSitesFlagUnset(self):
- self.TestUseLiveSitesFlag(expected_wpr_mode=wpr_modes.WPR_REPLAY)
+ self._TestUseLiveSitesFlag(expected_wpr_mode=wpr_modes.WPR_REPLAY)
def testConstructorCallsSetOptions(self):
test = DummyTest()
« no previous file with comments | « tools/telemetry/telemetry/page/shared_page_state.py ('k') | tools/telemetry/telemetry/testing/fakes/__init__.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698