Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: tools/telemetry/telemetry/internal/platform/platform_backend.py

Issue 1491183003: [Telemetry] Move WPR life cycle from browser to platform (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: work in progress Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/internal/platform/platform_backend.py
diff --git a/tools/telemetry/telemetry/internal/platform/platform_backend.py b/tools/telemetry/telemetry/internal/platform/platform_backend.py
index 9d5cef1a579c2880b7eed9dd837c70c4bc5bcef6..6b01edb4ebf62d1757bc4b59bc599e2c2b6cecff 100644
--- a/tools/telemetry/telemetry/internal/platform/platform_backend.py
+++ b/tools/telemetry/telemetry/internal/platform/platform_backend.py
@@ -4,6 +4,7 @@
import weakref
+from telemetry.internal import forwarders
from telemetry.internal.forwarders import do_nothing_forwarder
from telemetry.internal.platform import network_controller_backend
from telemetry.internal.platform import tracing_controller_backend
@@ -90,33 +91,17 @@ class PlatformBackend(object):
browser_options = browser_backend.browser_options
self.SetFullPerformanceModeEnabled(browser_options.full_performance_mode)
- # TODO(slamm): Remove this call when replay browser_backend dependencies
- # get moved to platform. https://crbug.com/423962
- self._network_controller_backend.UpdateReplay(browser_backend)
-
def DidStartBrowser(self, browser, browser_backend):
assert browser not in self._running_browser_backends
self._running_browser_backends.add(browser_backend)
def WillCloseBrowser(self, browser, browser_backend):
- # TODO(slamm): Move this call when replay's life cycle is no longer
- # tied to the browser. https://crbug.com/424777
- self._network_controller_backend.StopReplay()
-
is_last_browser = len(self._running_browser_backends) <= 1
if is_last_browser:
self.SetFullPerformanceModeEnabled(False)
self._running_browser_backends.discard(browser_backend)
- @property
- def wpr_http_device_port(self):
- return self._network_controller_backend.wpr_http_device_port
-
- @property
- def wpr_https_device_port(self):
- return self._network_controller_backend.wpr_https_device_port
-
def IsDisplayTracingSupported(self):
return False

Powered by Google App Engine
This is Rietveld 408576698