tools/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py - Issue 1491183003: [Telemetry] Move WPR life cycle from browser to platform

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py

Issue 1491183003: [Telemetry] Move WPR life cycle from browser to platform (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: work in progress Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py ('k') | tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py

diff --git a/tools/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py b/tools/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py

index 1231daa3ebf956b7a3aa7da44ba8d6b297c588ae..ee974cb7f992d6b82e8eee7d294874f64fa854e3 100644

--- a/tools/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py

+++ b/tools/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py

@@ -26,14 +26,6 @@ class CrOSBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

self._cri = cri

self._is_guest = is_guest

self._forwarder = None

- self.wpr_port_pairs = forwarders.PortPairs(

- http=forwarders.PortPair(self.wpr_port_pairs.http.local_port,

- self._platform_backend.GetRemotePort(

- self.wpr_port_pairs.http.local_port)),

- https=forwarders.PortPair(self.wpr_port_pairs.https.local_port,

- self._platform_backend.GetRemotePort(

- self.wpr_port_pairs.http.local_port)),

- dns=None)

self._remote_debugging_port = self._cri.GetRemotePort()

self._port = self._remote_debugging_port

@@ -117,6 +109,7 @@ class CrOSBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

self._cri.RunCmdOnDevice(args)

if not self._cri.local:

+ # TODO(crbug.com/404771): Move port forwarding to network_controller.

self._port = util.GetUnreservedAvailableLocalPort()

self._forwarder = self._platform_backend.forwarder_factory.Create(

forwarders.PortPairs(