Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 1491153002: X87: Array constructor failed to enter it's function execution context. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Array constructor failed to enter it's function execution context. port d2f78c6b7917b89b589e6d10e0282b14b3322e30 (r32476) original commit message: This becomes visible if an exception is thrown by the constructor. We do this on "new Array(3.5)", throwing a RangeError. BUG= Committed: https://crrev.com/487955067557d9999946d4e72bb81ba20e79b54e Cr-Commit-Position: refs/heads/master@{#32489}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-02 04:52:43 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-02 05:03:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491153002/1
5 years ago (2015-12-02 05:03:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 05:35:00 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-02 05:35:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/487955067557d9999946d4e72bb81ba20e79b54e
Cr-Commit-Position: refs/heads/master@{#32489}

Powered by Google App Engine
This is Rietveld 408576698