Issue 149113006: Patch Dartium branch of Chromium 1700 to run performance tests on buildbot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149113006: Patch Dartium branch of Chromium 1700 to run performance tests on buildbot (Closed)

Created:
6 years, 10 months ago by Bill Hesse

Modified:
6 years, 10 months ago

Reviewers:
vsm

CC:
reviews+dom_dartlang.org, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org, Søren Gjesse, ricow1

Base URL:
http://src.chromium.org/chrome/branches/dart/1700/src/

Visibility:
Public.

Patch Dartium branch of Chromium 1700 to run performance tests on buildbot The buildbot code requires an option in run_perf.py that was added after branch 1700. R=vsm@google.com Committed: https://src.chromium.org/viewvc/multivm/branches/1650/chrome?view=rev&revision=249028

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	tools/telemetry/telemetry/core/browser_options.py	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

Bill Hesse

This just makes run_perf.py ignore the new option, without crashing. This should not be needed ...

6 years, 10 months ago (2014-02-05 13:23:23 UTC) #1

vsm

lgtm Is this patch already in 1750 or just unnecessary there?

6 years, 10 months ago (2014-02-05 15:46:37 UTC) #2

Bill Hesse

Patch Dartium branch of Chromium 1700 to run performance tests on buildbot

6 years, 10 months ago (2014-02-05 17:02:45 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r249028.