Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 149113003: Findbugs: Fix public static fields in AwResource.java. (Closed)

Created:
6 years, 10 months ago by Lei Zhang
Modified:
6 years, 10 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, android-webview-reviews_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Findbugs: Fix public static fields in AwResource.java. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250233

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwResource.java View 1 1 chunk +3 lines, -3 lines 0 comments Download
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Lei Zhang
Note: I haven't written Java in years, hope this looks ok.
6 years, 10 months ago (2014-01-31 19:20:11 UTC) #1
mnaganov (inactive)
On 2014/01/31 19:20:11, Lei Zhang wrote: > Note: I haven't written Java in years, hope ...
6 years, 10 months ago (2014-02-03 08:56:58 UTC) #2
Lei Zhang
mnaganov: So is a reasonably approach to keep this public, but with the setters. Fix ...
6 years, 10 months ago (2014-02-05 00:55:09 UTC) #3
mnaganov (inactive)
On 2014/02/05 00:55:09, Lei Zhang wrote: > mnaganov: So is a reasonably approach to keep ...
6 years, 10 months ago (2014-02-05 08:49:44 UTC) #4
Lei Zhang
On 2014/02/05 08:49:44, Mikhail Naganov (Cr) wrote: > On 2014/02/05 00:55:09, Lei Zhang wrote: > ...
6 years, 10 months ago (2014-02-05 08:59:48 UTC) #5
Lei Zhang
And rebased.
6 years, 10 months ago (2014-02-07 22:46:07 UTC) #6
mnaganov (inactive)
lgtm
6 years, 10 months ago (2014-02-10 09:46:14 UTC) #7
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 10 months ago (2014-02-10 19:55:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/149113003/80001
6 years, 10 months ago (2014-02-10 19:58:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/149113003/80001
6 years, 10 months ago (2014-02-10 22:48:44 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-10 23:13:54 UTC) #11
Message was sent while issue was closed. 
Change committed as 250233

Powered by Google App Engine
This is Rietveld 408576698