Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1491123002: Speculative fix for null m_documentLoader in restoreScrollPositionAndViewState. (Closed)

Created:
5 years ago by skobes
Modified:
5 years ago
Reviewers:
Nate Chapin
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Speculative fix for null m_documentLoader in restoreScrollPositionAndViewState. BUG=537070 Committed: https://crrev.com/ec22fcd980c452a5dd347060c424a764e208b0e2 Cr-Commit-Position: refs/heads/master@{#363039}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
skobes
5 years ago (2015-12-02 04:31:39 UTC) #2
Nate Chapin
LGTM https://codereview.chromium.org/1491123002/diff/1/third_party/WebKit/Source/core/loader/FrameLoader.cpp File third_party/WebKit/Source/core/loader/FrameLoader.cpp (right): https://codereview.chromium.org/1491123002/diff/1/third_party/WebKit/Source/core/loader/FrameLoader.cpp#newcode1127 third_party/WebKit/Source/core/loader/FrameLoader.cpp:1127: if (!documentLoader()) Maybe add this to the first ...
5 years ago (2015-12-03 17:49:13 UTC) #3
skobes
https://codereview.chromium.org/1491123002/diff/1/third_party/WebKit/Source/core/loader/FrameLoader.cpp File third_party/WebKit/Source/core/loader/FrameLoader.cpp (right): https://codereview.chromium.org/1491123002/diff/1/third_party/WebKit/Source/core/loader/FrameLoader.cpp#newcode1127 third_party/WebKit/Source/core/loader/FrameLoader.cpp:1127: if (!documentLoader()) On 2015/12/03 17:49:13, Nate Chapin wrote: > ...
5 years ago (2015-12-03 18:40:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491123002/20001
5 years ago (2015-12-03 18:42:02 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 20:07:41 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-03 20:09:13 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ec22fcd980c452a5dd347060c424a764e208b0e2
Cr-Commit-Position: refs/heads/master@{#363039}

Powered by Google App Engine
This is Rietveld 408576698