Fix CFI buildbot: import chrome_build.gni for is_official_build.

Fix CFI buildbot: import chrome_build.gni for is_official_build.

BUG=481692, 561677
Committed: https://crrev.com/b84bb501f83db00e48e2b2a43b2f326afb179e98
Cr-Commit-Position: refs/heads/master@{#362753}

[krasin, 2015-12-02 03:54:30]

krasin@google.com changed reviewers:
+ dpranke@google.com

[krasin, 2015-12-02 03:54:30]

Hi Dirk,

this is one more bit to fix. Uncovered by CFI buildbot, when it finally ran:
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/3591

[krasin, 2015-12-02 03:54:41]

Description was changed from

==========
Fix CFI buildbot: import chrome_build.gni for is_official_build.

BUG=481692,561677
==========

to

==========
Fix CFI buildbot: import chrome_build.gni for is_official_build.

BUG=481692,561677
==========

[krasin, 2015-12-02 03:57:11]

On 2015/12/02 03:54:30, krasin wrote:
> Hi Dirk,
> 
> this is one more bit to fix. Uncovered by CFI buildbot, when it finally ran:
> https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/3591

This CL is a prerequisite for https://codereview.chromium.org/1393283005/
Technically, I could submit that CL, and everything *should* be good, but I want
to have CFI buildbot green first.

[krasin, 2015-12-02 17:12:08]

Nico, Dirk,

can you please approve this one-liner fix?

[Dirk Pranke, 2015-12-02 17:15:29]

On 2015/12/02 17:12:08, krasin wrote:
> Nico, Dirk,
> 
> can you please approve this one-liner fix?

It would probably be better to add the import to
//build/config/sanitizers/BUILD.gn directly; sanitizers.gni doesn't actually
use the is_official_build flag (yet), but the build file does, so this is more
of an "include what you use thing".

Then, when you land the other patch, have sanitizers.gni import it *also*.

Make sense?

[krasin, 2015-12-02 17:21:31]

On 2015/12/02 17:15:29, Dirk Pranke wrote:
> On 2015/12/02 17:12:08, krasin wrote:
> > Nico, Dirk,
> > 
> > can you please approve this one-liner fix?
> 
> It would probably be better to add the import to
> //build/config/sanitizers/BUILD.gn directly; sanitizers.gni doesn't actually
> use the is_official_build flag (yet), but the build file does, so this is more
> of an "include what you use thing".
> 
> Then, when you land the other patch, have sanitizers.gni import it *also*.
> 
> Make sense?

Yes, that makes perfect sense. Thanks for the suggestion. Done.

The added empty line are from 'gn format'.

[Dirk Pranke, 2015-12-02 17:25:46]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2015-12-02 17:25:47]

lgtm, thanks!

[krasin, 2015-12-02 17:26:36]

The CQ bit was checked by krasin@google.com

[commit-bot: I haz the power, 2015-12-02 17:27:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1491113002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1491113002/20001

[commit-bot: I haz the power, 2015-12-02 18:31:10]

Description was changed from

==========
Fix CFI buildbot: import chrome_build.gni for is_official_build.

BUG=481692,561677
==========

to

==========
Fix CFI buildbot: import chrome_build.gni for is_official_build.

BUG=481692,561677
==========

[commit-bot: I haz the power, 2015-12-02 18:31:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-02 18:31:47]

Description was changed from

==========
Fix CFI buildbot: import chrome_build.gni for is_official_build.

BUG=481692,561677
==========

to

==========
Fix CFI buildbot: import chrome_build.gni for is_official_build.

BUG=481692,561677

Committed: https://crrev.com/b84bb501f83db00e48e2b2a43b2f326afb179e98
Cr-Commit-Position: refs/heads/master@{#362753}
==========

[commit-bot: I haz the power, 2015-12-02 18:31:48]

Patchset 2 (id:??) landed as
https://crrev.com/b84bb501f83db00e48e2b2a43b2f326afb179e98
Cr-Commit-Position: refs/heads/master@{#362753}