Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Side by Side Diff: chrome/browser/ui/search/search_model.cc

Issue 14911005: Move instant support to SearchTabHelper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed instant support code from InstantPage Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/search/search_model.h" 5 #include "chrome/browser/ui/search/search_model.h"
6 6
7 #include "chrome/browser/search/search.h" 7 #include "chrome/browser/search/search.h"
8 #include "chrome/browser/ui/search/search_model_observer.h" 8 #include "chrome/browser/ui/search/search_model_observer.h"
9 9
10 SearchModel::State::State()
11 : top_bars_visible(true),
12 instant_support(INSTANT_SUPPORT_UNKNOWN) {
13 }
14
15 SearchModel::State::State(const SearchMode& mode,
16 bool top_bars_visible,
17 InstantSupportState instant_support)
18 : mode(mode),
19 top_bars_visible(top_bars_visible),
20 instant_support(instant_support) {
21 }
22
23 bool SearchModel::State::operator==(const State& rhs) const {
24 return mode == rhs.mode && top_bars_visible == rhs.top_bars_visible &&
25 instant_support == rhs.instant_support;
26 }
27
10 SearchModel::SearchModel() { 28 SearchModel::SearchModel() {
11 } 29 }
12 30
13 SearchModel::~SearchModel() { 31 SearchModel::~SearchModel() {
14 } 32 }
15 33
16 // static. 34 // static.
17 bool SearchModel::ShouldChangeTopBarsVisibility(const State& old_state, 35 bool SearchModel::ShouldChangeTopBarsVisibility(const State& old_state,
18 const State& new_state) { 36 const State& new_state) {
19 // If mode has changed, only change top bars visibility if new mode is not 37 // If mode has changed, only change top bars visibility if new mode is not
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 if (state_.top_bars_visible == visible) 88 if (state_.top_bars_visible == visible)
71 return; 89 return;
72 90
73 const State old_state = state_; 91 const State old_state = state_;
74 state_.top_bars_visible = visible; 92 state_.top_bars_visible = visible;
75 93
76 FOR_EACH_OBSERVER(SearchModelObserver, observers_, 94 FOR_EACH_OBSERVER(SearchModelObserver, observers_,
77 ModelChanged(old_state, state_)); 95 ModelChanged(old_state, state_));
78 } 96 }
79 97
98 void SearchModel::SetSupportsInstant(bool supports_instant) {
samarth 2013/05/10 01:32:38 Can we follow Jered's lead in InstantPage and add
kmadhusu 2013/05/13 17:13:24 Done.
99 DCHECK(chrome::IsInstantExtendedAPIEnabled())
100 << "Please do not try to set the SearchModel mode without first "
101 << "checking if Search is enabled.";
102
103 InstantSupportState new_instant_support = supports_instant ?
104 INSTANT_SUPPORT_YES : INSTANT_SUPPORT_NO;
105
106 if (state_.instant_support == new_instant_support)
107 return;
108
109 const State old_state = state_;
110 state_.instant_support = new_instant_support;
111
112 FOR_EACH_OBSERVER(SearchModelObserver, observers_,
113 ModelChanged(old_state, state_));
114 }
115
80 void SearchModel::AddObserver(SearchModelObserver* observer) { 116 void SearchModel::AddObserver(SearchModelObserver* observer) {
81 observers_.AddObserver(observer); 117 observers_.AddObserver(observer);
82 } 118 }
83 119
84 void SearchModel::RemoveObserver(SearchModelObserver* observer) { 120 void SearchModel::RemoveObserver(SearchModelObserver* observer) {
85 observers_.RemoveObserver(observer); 121 observers_.RemoveObserver(observer);
86 } 122 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698