Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Unified Diff: gin/public/isolate_holder.h

Issue 1491083002: Set V8 extras mode in gin::V8Initializer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/isolate_holder.cc ('k') | gin/shell/gin_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/public/isolate_holder.h
diff --git a/gin/public/isolate_holder.h b/gin/public/isolate_holder.h
index f7e01e8aee80ba004942a71f49684df1642f156c..6ce302b14b2fc041e433970da4e12e34fbe5e9c5 100644
--- a/gin/public/isolate_holder.h
+++ b/gin/public/isolate_holder.h
@@ -35,6 +35,12 @@ class GIN_EXPORT IsolateHolder {
kUseLocker
};
+ // Indicates whether V8 works with stable or experimental v8 extras.
+ enum V8ExtrasMode {
+ kStableV8Extras,
+ kStableAndExperimentalV8Extras,
+ };
+
IsolateHolder();
explicit IsolateHolder(AccessMode access_mode);
~IsolateHolder();
@@ -48,6 +54,7 @@ class GIN_EXPORT IsolateHolder {
// V8Initializer::LoadV8SnapshotFromFD or
// V8Initializer::LoadV8Snapshot) before calling this method.
static void Initialize(ScriptMode mode,
+ V8ExtrasMode v8_extras_mode,
v8::ArrayBuffer::Allocator* allocator);
v8::Isolate* isolate() { return isolate_; }
« no previous file with comments | « gin/isolate_holder.cc ('k') | gin/shell/gin_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698