Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: gin/public/isolate_holder.h

Issue 1491083002: Set V8 extras mode in gin::V8Initializer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gin/public/isolate_holder.h
diff --git a/gin/public/isolate_holder.h b/gin/public/isolate_holder.h
index f7e01e8aee80ba004942a71f49684df1642f156c..d43ffb2f5a4db810956aa98842d9665d6cd0f18a 100644
--- a/gin/public/isolate_holder.h
+++ b/gin/public/isolate_holder.h
@@ -35,6 +35,12 @@ class GIN_EXPORT IsolateHolder {
kUseLocker
};
+ // Indicates whether V8 works with stable or experimental v8 extras.
+ enum V8ExtrasMode {
+ kStableV8Extras,
+ kExperimentalV8Extras,
domenic 2015/12/02 18:07:23 It'd be less confusing to name this kStableAndExpe
yhirano 2015/12/03 02:21:05 Done.
+ };
+
IsolateHolder();
explicit IsolateHolder(AccessMode access_mode);
~IsolateHolder();
@@ -48,7 +54,12 @@ class GIN_EXPORT IsolateHolder {
// V8Initializer::LoadV8SnapshotFromFD or
// V8Initializer::LoadV8Snapshot) before calling this method.
static void Initialize(ScriptMode mode,
+ V8ExtrasMode v8_extras_mode,
v8::ArrayBuffer::Allocator* allocator);
+ static void Initialize(ScriptMode mode,
jochen (gone - plz use gerrit) 2015/12/02 13:09:18 please add the parameter explicitly everywhere
yhirano 2015/12/03 02:21:05 Done.
+ v8::ArrayBuffer::Allocator* allocator) {
+ Initialize(mode, kStableV8Extras, allocator);
+ }
v8::Isolate* isolate() { return isolate_; }

Powered by Google App Engine
This is Rietveld 408576698