Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Side by Side Diff: gin/test/v8_test.cc

Issue 1491083002: Set V8 extras mode in gin::V8Initializer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gin/test/file_runner.cc ('k') | gin/v8_initializer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gin/test/v8_test.h" 5 #include "gin/test/v8_test.h"
6 6
7 #include "gin/array_buffer.h" 7 #include "gin/array_buffer.h"
8 #include "gin/public/isolate_holder.h" 8 #include "gin/public/isolate_holder.h"
9 #include "gin/v8_initializer.h" 9 #include "gin/v8_initializer.h"
10 10
11 using v8::Context; 11 using v8::Context;
12 using v8::Local; 12 using v8::Local;
13 using v8::HandleScope; 13 using v8::HandleScope;
14 14
15 namespace gin { 15 namespace gin {
16 16
17 V8Test::V8Test() { 17 V8Test::V8Test() {
18 } 18 }
19 19
20 V8Test::~V8Test() { 20 V8Test::~V8Test() {
21 } 21 }
22 22
23 void V8Test::SetUp() { 23 void V8Test::SetUp() {
24 #ifdef V8_USE_EXTERNAL_STARTUP_DATA 24 #ifdef V8_USE_EXTERNAL_STARTUP_DATA
25 gin::V8Initializer::LoadV8Snapshot(); 25 gin::V8Initializer::LoadV8Snapshot();
26 gin::V8Initializer::LoadV8Natives(); 26 gin::V8Initializer::LoadV8Natives();
27 #endif 27 #endif
28 gin::IsolateHolder::Initialize(gin::IsolateHolder::kStrictMode, 28 gin::IsolateHolder::Initialize(gin::IsolateHolder::kStrictMode,
29 gin::IsolateHolder::kStableV8Extras,
29 gin::ArrayBufferAllocator::SharedInstance()); 30 gin::ArrayBufferAllocator::SharedInstance());
30 31
31 instance_.reset(new gin::IsolateHolder); 32 instance_.reset(new gin::IsolateHolder);
32 instance_->isolate()->Enter(); 33 instance_->isolate()->Enter();
33 HandleScope handle_scope(instance_->isolate()); 34 HandleScope handle_scope(instance_->isolate());
34 context_.Reset(instance_->isolate(), Context::New(instance_->isolate())); 35 context_.Reset(instance_->isolate(), Context::New(instance_->isolate()));
35 Local<Context>::New(instance_->isolate(), context_)->Enter(); 36 Local<Context>::New(instance_->isolate(), context_)->Enter();
36 } 37 }
37 38
38 void V8Test::TearDown() { 39 void V8Test::TearDown() {
39 { 40 {
40 HandleScope handle_scope(instance_->isolate()); 41 HandleScope handle_scope(instance_->isolate());
41 Local<Context>::New(instance_->isolate(), context_)->Exit(); 42 Local<Context>::New(instance_->isolate(), context_)->Exit();
42 context_.Reset(); 43 context_.Reset();
43 } 44 }
44 instance_->isolate()->Exit(); 45 instance_->isolate()->Exit();
45 instance_.reset(); 46 instance_.reset();
46 } 47 }
47 48
48 } // namespace gin 49 } // namespace gin
OLDNEW
« no previous file with comments | « gin/test/file_runner.cc ('k') | gin/v8_initializer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698