Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1491063003: X87: Provide call counts for constructor calls, surface them as a vector IC. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Provide call counts for constructor calls, surface them as a vector IC. port 66d5a9df62da458a51e8c7ed1811dc9660f4f418 (r32452) original commit message: CallIC and CallConstructStub look so alike, at least in the feedback they gather even if the implementation differs...and CallIC has such a nice way of surfacing the feedback (CallICNexus), that there BUG= Committed: https://crrev.com/54a9d349db405b4618f1bd140c12eb2129c8ae1e Cr-Commit-Position: refs/heads/master@{#32488}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -8 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 5 chunks +17 lines, -3 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-02 03:20:36 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-02 05:02:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491063003/1
5 years ago (2015-12-02 05:03:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 05:26:39 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-02 05:26:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54a9d349db405b4618f1bd140c12eb2129c8ae1e
Cr-Commit-Position: refs/heads/master@{#32488}

Powered by Google App Engine
This is Rietveld 408576698