Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1491043004: Fixes document type detection on iOS 9. (Closed)

Created:
5 years ago by bzanotti
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Fixes document type detection on iOS 9. On iOS 9, evaluating '' + document always results in [object HTMLDocument], even for PDFs. This introduces another way of checking document type on iOS 9. Unfortunately, it doesn't work on iOS 8, so the old implementation needs to stay too. BUG=549604 Review URL: https://codereview.chromium.org/1458703004 Cr-Commit-Position: refs/heads/master@{#361095} (cherry picked from commit 704def3b29d00bf39aca6553a079152171af4ad9) Committed: https://chromium.googlesource.com/chromium/src/+/f5f194b3efbdfc92886eebe0b359a25518061fe0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -18 lines) Patch
M ios/web/web_state/ui/crw_ui_web_view_web_controller.mm View 2 chunks +20 lines, -7 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +14 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller+protected.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_web_view_web_controller.mm View 1 chunk +2 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
bzanotti
Committed patchset #1 (id:1) manually as f5f194b3efbdfc92886eebe0b359a25518061fe0 (tree was closed).
5 years ago (2015-12-02 16:40:49 UTC) #2
bzanotti
5 years ago (2015-12-02 16:43:34 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1491263002/ by bzanotti@chromium.org.

The reason for reverting is: No approval for this cherry-pick. Reverting..

Powered by Google App Engine
This is Rietveld 408576698