Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 1491043002: Don't swap processes for frames embedded in DevTools pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Another chromium.fyi.json conflict Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | testing/buildbot/chromium.fyi.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_manager.cc
diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc
index 9dbe59ee237b2e27ce558d0fdbde93cb0c2d0ffc..67a150e11a6ac9700f05fa5aa63cc57d0bd0075a 100644
--- a/content/browser/frame_host/render_frame_host_manager.cc
+++ b/content/browser/frame_host/render_frame_host_manager.cc
@@ -1572,6 +1572,14 @@ bool RenderFrameHostManager::IsRendererTransferNeededForNavigation(
if (rfh->GetSiteInstance()->GetSiteURL().SchemeIs(kGuestScheme))
return false;
+ // Don't swap processes for extensions embedded in DevTools. See
+ // https://crbug.com/564216.
+ if (rfh->GetSiteInstance()->GetSiteURL().SchemeIs(kChromeDevToolsScheme)) {
+ CHECK(!dest_url.SchemeIs(url::kHttpScheme) &&
+ !dest_url.SchemeIs(url::kHttpsScheme));
+ return false;
+ }
+
BrowserContext* context = rfh->GetSiteInstance()->GetBrowserContext();
GURL effective_url = SiteInstanceImpl::GetEffectiveURL(context, dest_url);
« no previous file with comments | « no previous file | testing/buildbot/chromium.fyi.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698