android envsetup: Remove default_target=All

android envsetup: Remove default_target=All

If targets shouldn't be part of the android build, they should be conditional
in gyp instead.

Removing this line leads to 17 more files being compiled and one more binary
(printing_unittests) being linked on the open source bots, and there are no
build errors.

(An internal build of the 'all' target is also successful, and it builds only
183 additional edges too, which add about 1 minute / 5% to build time.)

BUG=330631
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247571

[Nico, 2014-01-28 22:07:33]

Hey Yaron, do you want to stamp this? Then I can land it a day earlier :-)

[Yaron, 2014-01-28 22:20:33]

On 2014/01/28 22:07:33, Nico wrote:
> Hey Yaron, do you want to stamp this? Then I can land it a day earlier :-)

lgtm

[Yaron, 2014-01-28 22:21:43]

On 2014/01/28 22:20:33, Yaron wrote:
> On 2014/01/28 22:07:33, Nico wrote:
> > Hey Yaron, do you want to stamp this? Then I can land it a day earlier :-)
> 
> lgtm

Doesn't this mean you could also obviate the need for |android_app_target| since
anything that's defined will get built? Or actually, I guess not since bots
build the All target

[Nico, 2014-01-28 22:26:12]

On Tue, Jan 28, 2014 at 2:21 PM, <yfriedman@chromium.org> wrote:

> On 2014/01/28 22:20:33, Yaron wrote:
>
>> On 2014/01/28 22:07:33, Nico wrote:
>> > Hey Yaron, do you want to stamp this? Then I can land it a day earlier
>> :-)
>>
>
>  lgtm
>>
>
> Doesn't this mean you could also obviate the need for |android_app_target|
> since
> anything that's defined will get built? Or actually, I guess not since bots
> build the All target
>

Editing build/android/buildbot/bb_host_steps.py to say "all" instead of
"All" is easy enough. I don't know how the internal bots build, though.


>
> https://codereview.chromium.org/149103002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-01-28 22:39:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/149103002/1

[commit-bot: I haz the power, 2014-01-29 01:36:40]

Change committed as 247571