third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp - Issue 1491023003: Refactor SVGAnimatedLength negative values mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp

Issue 1491023003: Refactor SVGAnimatedLength negative values mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace SVGLengthNegativeValuesMode enum with bool Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp b/third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp

index c40715f35cf9741b1c3529750f103efeabd92936..343cb3404b1e0f324b588d129f89f4dcdb528466 100644

--- a/third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp

@@ -50,7 +50,7 @@ template<> const SVGEnumerationStringEntries& getStaticStringEntries<SVGTextPath

inline SVGTextPathElement::SVGTextPathElement(Document& document)

: SVGTextContentElement(SVGNames::textPathTag, document)

, SVGURIReference(this)

- , m_startOffset(SVGAnimatedLength::create(this, SVGNames::startOffsetAttr, SVGLength::create(SVGLengthMode::Width), AllowNegativeLengths))

+ , m_startOffset(SVGAnimatedLength::create(this, SVGNames::startOffsetAttr, SVGLength::create(SVGLengthMode::Width)))

, m_method(SVGAnimatedEnumeration<SVGTextPathMethodType>::create(this, SVGNames::methodAttr, SVGTextPathMethodAlign))

, m_spacing(SVGAnimatedEnumeration<SVGTextPathSpacingType>::create(this, SVGNames::spacingAttr, SVGTextPathSpacingExact))

{