Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp

Issue 1491023003: Refactor SVGAnimatedLength negative values mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Replace SVGLengthNegativeValuesMode enum with bool Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 15 matching lines...) Expand all
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "config.h" 31 #include "config.h"
32 32
33 #include "core/svg/SVGAnimatedLength.h" 33 #include "core/svg/SVGAnimatedLength.h"
34 34
35 #include "core/svg/SVGElement.h" 35 #include "core/svg/SVGElement.h"
36 #include "core/svg/SVGLength.h"
36 37
37 namespace blink { 38 namespace blink {
38 39
39 void SVGAnimatedLength::setDefaultValueAsString(const String& value) 40 void SVGAnimatedLength::setDefaultValueAsString(const String& value)
40 { 41 {
41 baseValue()->setValueAsString(value, ASSERT_NO_EXCEPTION); 42 baseValue()->setValueAsString(value, ASSERT_NO_EXCEPTION);
42 } 43 }
43 44
44 void SVGAnimatedLength::setBaseValueAsString(const String& value, SVGParsingErro r& parseError) 45 void SVGAnimatedLength::setBaseValueAsString(const String& value, SVGParsingErro r& parseError)
45 { 46 {
46 TrackExceptionState es; 47 TrackExceptionState es;
47 48
48 baseValue()->setValueAsString(value, es); 49 baseValue()->setValueAsString(value, es);
49 50
50 if (es.hadException()) { 51 if (es.hadException()) {
51 parseError = ParsingAttributeFailedError; 52 parseError = ParsingAttributeFailedError;
52 baseValue()->newValueSpecifiedUnits(CSSPrimitiveValue::UnitType::UserUni ts, 0); 53 baseValue()->newValueSpecifiedUnits(CSSPrimitiveValue::UnitType::UserUni ts, 0);
53 } else if (m_negativeValuesMode == ForbidNegativeLengths && baseValue()->val ueInSpecifiedUnits() < 0) { 54 } else if (SVGLength::negativeValuesForbiddenForAnimatedLengthAttribute(attr ibuteName()) && baseValue()->valueInSpecifiedUnits() < 0) {
54 parseError = NegativeValueForbiddenError; 55 parseError = NegativeValueForbiddenError;
55 } 56 }
56 } 57 }
57 58
58 } 59 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGAnimatedLength.h ('k') | third_party/WebKit/Source/core/svg/SVGCircleElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698