Issue 149102: Fix a crash that happens when changing themes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149102: Fix a crash that happens when changing themes. (Closed)

Created:
11 years, 6 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix a crash that happens when changing themes. We were holding references to images that got deleted when themes changed. These all happen to be in a NineBox, so have NineBox reload images when the theme change notification is sent. Also fix an expose bug that wasn't noticeable in the original theme. We need to always place the image at 0, 0 for the background and paint it all the way across the window (should get clipped by cairo). BUG=15366

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -22 lines)			Patch
M	chrome/browser/gtk/browser_window_gtk.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/nine_box.h	View	3 chunks	+17 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/nine_box.cc	View	3 chunks	+35 lines, -19 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

lgtm on another note, does theme provider cache the pixbufs the way the resource bundle ...

11 years, 6 months ago (2009-06-26 21:42:00 UTC) #2

tony

11 years, 6 months ago (2009-06-26 21:43:28 UTC) #3

On 2009/06/26 21:42:00, Evan Stade wrote:
> lgtm
> 
> on another note, does theme provider cache the pixbufs the way the resource
> bundle does? I think that was a mental TODO I had but didn't put in the code

Yes, it does cache.  See browser/browser_theme_provider_gtk.cc.

Expand Messages | Collapse Messages