Add a caseSensitive flag to new Glob().

Add a caseSensitive flag to new Glob().

Closes #3

R=rnystrom@google.com

Committed: https://github.com/dart-lang/glob/commit/445a10bcceb10f0c195c13ed68878421d1278059

[Bob Nystrom, 2015-12-02 01:01:43]

https://codereview.chromium.org/1491003002/diff/1/README.md
File README.md (right):

https://codereview.chromium.org/1491003002/diff/1/README.md#newcode54
README.md:54: case-sensitive by default on Windows.
"insensitive"

https://codereview.chromium.org/1491003002/diff/1/lib/glob.dart
File lib/glob.dart (right):

https://codereview.chromium.org/1491003002/diff/1/lib/glob.dart#newcode94
lib/glob.dart:94: /// and directories it explicitly lists, but anything beneath
those as well.
"lists" -> "matches"?

https://codereview.chromium.org/1491003002/diff/1/lib/glob.dart#newcode96
lib/glob.dart:96: /// If [caseSensitive] is true, this glob will match and list
only files whose
"will match" -> "matches", etc.

https://codereview.chromium.org/1491003002/diff/1/test/list_test.dart
File test/list_test.dart (right):

https://codereview.chromium.org/1491003002/diff/1/test/list_test.dart#newcode76
test/list_test.dart:76: });
Why do these all throw?

[nweiz, 2015-12-02 01:32:56]

Code review changes

[nweiz, 2015-12-02 01:33:01]

https://codereview.chromium.org/1491003002/diff/1/README.md
File README.md (right):

https://codereview.chromium.org/1491003002/diff/1/README.md#newcode54
README.md:54: case-sensitive by default on Windows.
On 2015/12/02 01:01:43, Bob Nystrom wrote:
> "insensitive"

Done.

https://codereview.chromium.org/1491003002/diff/1/lib/glob.dart
File lib/glob.dart (right):

https://codereview.chromium.org/1491003002/diff/1/lib/glob.dart#newcode94
lib/glob.dart:94: /// and directories it explicitly lists, but anything beneath
those as well.
On 2015/12/02 01:01:43, Bob Nystrom wrote:
> "lists" -> "matches"?

Done.

https://codereview.chromium.org/1491003002/diff/1/lib/glob.dart#newcode96
lib/glob.dart:96: /// If [caseSensitive] is true, this glob will match and list
only files whose
On 2015/12/02 01:01:43, Bob Nystrom wrote:
> "will match" -> "matches", etc.

Done.

https://codereview.chromium.org/1491003002/diff/1/test/list_test.dart
File test/list_test.dart (right):

https://codereview.chromium.org/1491003002/diff/1/test/list_test.dart#newcode76
test/list_test.dart:76: });
On 2015/12/02 01:01:43, Bob Nystrom wrote:
> Why do these all throw?

Since you're explicitly declaring which files you expect to exist, and they
don't, so it should fail for the same reason a normal Directory.list() on a
non-existent file fails.

[Bob Nystrom, 2016-01-13 01:35:14]

lgtm

[nweiz, 2016-01-13 01:40:37]

Description was changed from

==========
Add a caseSensitive flag to new Glob().

Closes #3

R=rnystrom@google.com
==========

to

==========
Add a caseSensitive flag to new Glob().

Closes #3

R=rnystrom@google.com

Committed:
https://github.com/dart-lang/glob/commit/445a10bcceb10f0c195c13ed68878421d127...
==========

[nweiz, 2016-01-13 01:40:39]

Committed patchset #2 (id:20001) manually as
445a10bcceb10f0c195c13ed68878421d1278059 (presubmit successful).