Issue 14910008: Standardize naming of WebRuntimeFeatures functions for easier autogeneration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14910008: Standardize naming of WebRuntimeFeatures functions for easier autogeneration (Closed)

Created:
7 years, 7 months ago by eseidel

Modified:
7 years, 7 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, jamesr, abarth_chromum.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

This makes the functions all match the naming used in Blink's RuntimeEnabledFeatures.in. This will make them much easier to autogenerate. Some of these will require a 2-sided change, so I've left some helper functions to map to the new names. I don't believe anyone ever calls the isFooEnabled functions in Content/Chrome so we will may end up removing those during autogeneration. BUG=237740 R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149827

Patch Set 1 #

Patch Set 2 : Ready for review #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -20 lines)			Patch
	M	Source/WebKit/chromium/public/WebRuntimeFeatures.h	View	1	6 chunks	+14 lines, -9 lines	0 comments	Download
	M	Source/WebKit/chromium/src/WebRuntimeFeatures.cpp	View	1	6 chunks	+11 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/14910008/2001

7 years, 7 months ago (2013-05-07 00:29:27 UTC) #3

eseidel

7 years, 7 months ago (2013-05-07 00:36:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r149827 (presubmit successful).

Expand Messages | Collapse Messages