Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 1490953002: Switches to using document selection changed event instead of text selection changed on Windows. (Closed)

Created:
5 years ago by nektarios
Modified:
5 years ago
Reviewers:
dmazzoni
CC:
aboxhall+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, jam, je_julie, nektar+watch_chromium.org, plundblad+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switches to using document selection changed event instead of text selection changed on Windows. Ultimately it will be done for all platforms and text selection changed will be deprecated. TESTED=manual testing with Jaws and NVDA using textareas, input and content editables BUG=558710 R=dmazzoni@chromium.org Committed: https://crrev.com/76e3c107d3dcf1517590ae7daf166ff6882e3d21 Cr-Commit-Position: refs/heads/master@{#363011}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M content/browser/accessibility/browser_accessibility_manager_win.cc View 4 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
nektarios
5 years ago (2015-12-01 23:00:43 UTC) #2
dmazzoni
lgtm
5 years ago (2015-12-03 16:22:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490953002/1
5 years ago (2015-12-03 16:23:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/116813)
5 years ago (2015-12-03 16:35:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490953002/1
5 years ago (2015-12-03 17:38:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 18:29:10 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-03 18:30:54 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76e3c107d3dcf1517590ae7daf166ff6882e3d21
Cr-Commit-Position: refs/heads/master@{#363011}

Powered by Google App Engine
This is Rietveld 408576698