Issue 1490933002: New NodeLocator which uses positions of characters, not between them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1490933002: New NodeLocator which uses positions of characters, not between them. (Closed)

Created:
5 years ago by scheglov

Modified:
5 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+120 lines, -9 lines)			Patch
M	pkg/analyzer/lib/src/generated/ast.dart	View	1 chunk	+89 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/dart.dart	View	1 chunk	+1 line, -9 lines	0 comments	Download
M	pkg/analyzer/test/generated/ast_test.dart	View	2 chunks	+30 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Brian Wilkerson

LGTM. At some point it would be good to copy over the existing NodeLocator tests ...

5 years ago (2015-12-01 21:45:41 UTC) #2

scheglov

5 years ago (2015-12-01 21:59:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1b9c263b56caab7200319b3b79fa44199af47c2c (presubmit successful).