Issue 149093011: Fix for buildbot failure after r19102.

Issue 149093011: Fix for buildbot failure after r19102. (Closed)

Created:
6 years, 10 months ago by Igor Sheludko

Modified:
6 years, 10 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix for buildbot failure after r19102. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19105

Patch Set 2 : Review notes applied #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -5 lines)			Patch
	M	src/hydrogen-check-elimination.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	src/hydrogen-instructions.h	View	1	1 chunk	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

lgtm with nits https://codereview.chromium.org/149093011/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/149093011/diff/1/src/hydrogen-instructions.h#newcode2660 src/hydrogen-instructions.h:2660: static HCheckMaps* New(Zone* zone, HValue* context, ...

6 years, 10 months ago (2014-02-05 15:17:07 UTC) #2

Igor Sheludko

Committed patchset #2 manually as r19105 (tree was closed).

6 years, 10 months ago (2014-02-05 15:23:00 UTC) #3

Igor Sheludko

6 years, 10 months ago (2014-02-05 15:24:11 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/149093011/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/149093011/diff/1/src/hydrogen-instructions.h#...
src/hydrogen-instructions.h:2660: static HCheckMaps* New(Zone* zone, HValue*
context,
On 2014/02/05 15:17:07, Toon Verwaest wrote:
> // HCheckMaps creation method safe for using during concurrent compilation
(does
> not dereference maps handles).

Done.

https://codereview.chromium.org/149093011/diff/1/src/hydrogen-instructions.h#...
src/hydrogen-instructions.h:2662: HValue *typecheck,
On 2014/02/05 15:17:07, Toon Verwaest wrote:
> HValue* typecheck

Done.

https://codereview.chromium.org/149093011/diff/1/src/hydrogen-instructions.h#...
src/hydrogen-instructions.h:2667: // creation of this object.
On 2014/02/05 15:17:07, Toon Verwaest wrote:
> Replace this comment with the comment above.

Done.

Expand Messages | Collapse Messages