Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 149093004: Fixed regression caused by 179554 which changed the meaning of ToggleFullscreenMode(). Updated Brow… (Closed)

Created:
6 years, 10 months ago by magnus
Modified:
6 years, 10 months ago
Reviewers:
scheib, James Hawkins
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixed regression caused by 179554 which changed the meaning of ToggleFullscreenMode(). Updated BrowserWindowCocoa::Show() accordingly. BUG=222605 TEST=(1) Start Chrome and enter fullscreen mode. (2) Quit and restart. (3) Verify that Chrome started in fullscreen mode, not presentation mode. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247743

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
magnus
6 years, 10 months ago (2014-01-29 01:30:06 UTC) #1
scheib
lgtm, and thanks. Please add a TEST= line with manual testing instructions clearly listed.
6 years, 10 months ago (2014-01-29 05:10:20 UTC) #2
magnus
On 2014/01/29 05:10:20, scheib wrote: > lgtm, and thanks. Please add a TEST= line with ...
6 years, 10 months ago (2014-01-29 05:26:30 UTC) #3
James Hawkins
lgtm
6 years, 10 months ago (2014-01-29 17:31:16 UTC) #4
magnus
On 2014/01/29 17:31:16, James Hawkins wrote: > lgtm Great. Would either of you be able ...
6 years, 10 months ago (2014-01-29 17:44:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fuzzac@gmail.com/149093004/1
6 years, 10 months ago (2014-01-29 17:47:06 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) remoting_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=218038
6 years, 10 months ago (2014-01-29 18:41:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fuzzac@gmail.com/149093004/1
6 years, 10 months ago (2014-01-29 19:09:51 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 21:32:43 UTC) #9
Message was sent while issue was closed.
Change committed as 247743

Powered by Google App Engine
This is Rietveld 408576698