Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1490923003: dart2js: Guard against imprecise inferred types (Closed)

Created:
5 years ago by sra1
Modified:
5 years ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Guard against imprecise inferred types For some reason html.Element's static const _tagsForWhichCreateContextualFragmentIsNotSupported is inferred to dynamic instead of a ContainerTypeMask. This change will also 'do the right thing' if we turn off type inference. R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/aec20f4a5bb32ef9043625dba245ca843bb6e7dd

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_mask_system.dart View 1 1 chunk +12 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sra1
5 years ago (2015-12-01 22:10:05 UTC) #3
asgerf
If this is something that should be fixed in the type inference, I think there ...
5 years ago (2015-12-02 10:06:52 UTC) #4
sra1
5 years ago (2015-12-02 22:04:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
aec20f4a5bb32ef9043625dba245ca843bb6e7dd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698