Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1490883002: Move remaining independent transform properties into CSSPropertyParser (Closed)

Created:
5 years ago by rwlbuis
Modified:
5 years ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move remaining independent transform properties into CSSPropertyParser Move remaining independent transform properties [1] handling from LegacyCSSPropertyParser into CSSPropertyParser. [1] https://drafts.csswg.org/css-transforms-2 BUG=499780 Committed: https://crrev.com/339300cc400108735ee43c15d1a7248f99bc86fc Cr-Commit-Position: refs/heads/master@{#362606}

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 2

Patch Set 3 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -46 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 2 chunks +39 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 2 chunks +2 lines, -46 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
rwlbuis
PTAL.
5 years ago (2015-12-01 22:21:35 UTC) #4
Timothy Loh
lgtm https://codereview.chromium.org/1490883002/diff/10003/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/1490883002/diff/10003/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode1070 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:1070: RefPtrWillBeRawPtr<CSSValue> dimension = consumeNumber(range, ValueRangeAll); dimension -> scale? ...
5 years ago (2015-12-02 00:45:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490883002/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490883002/30001
5 years ago (2015-12-02 01:05:46 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:30001)
5 years ago (2015-12-02 02:50:30 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-02 02:51:11 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/339300cc400108735ee43c15d1a7248f99bc86fc
Cr-Commit-Position: refs/heads/master@{#362606}

Powered by Google App Engine
This is Rietveld 408576698