Issue 1490853002: Correct overflow check; signed integer overflow is undefined

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1490853002: Correct overflow check; signed integer overflow is undefined (Closed)

Created:
5 years ago by srdjan

Modified:
5 years ago

Reviewers:
zra, Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -13 lines)			Patch
	M	runtime/vm/object.cc	View	1	1 chunk	+2 lines, -13 lines	0 comments	Download

Total messages: 6 (3 generated)

srdjan

5 years ago (2015-12-02 16:45:45 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
abef5cb3edda72d789bd19104f5f2172f4377448 (presubmit successful).