Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: src/a64/lithium-codegen-a64.cc

Issue 149083004: A64: Use the result of compare IC in StringCompareAndBranch. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Use EmitCompareAndBranch Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5090 matching lines...) Expand 10 before | Expand all | Expand 10 after
5101 5101
5102 void LCodeGen::DoStringCompareAndBranch(LStringCompareAndBranch* instr) { 5102 void LCodeGen::DoStringCompareAndBranch(LStringCompareAndBranch* instr) {
5103 Token::Value op = instr->op(); 5103 Token::Value op = instr->op();
5104 5104
5105 Handle<Code> ic = CompareIC::GetUninitialized(isolate(), op); 5105 Handle<Code> ic = CompareIC::GetUninitialized(isolate(), op);
5106 CallCode(ic, RelocInfo::CODE_TARGET, instr); 5106 CallCode(ic, RelocInfo::CODE_TARGET, instr);
5107 InlineSmiCheckInfo::EmitNotInlined(masm()); 5107 InlineSmiCheckInfo::EmitNotInlined(masm());
5108 5108
5109 Condition condition = TokenToCondition(op, false); 5109 Condition condition = TokenToCondition(op, false);
5110 5110
5111 EmitBranch(instr, condition); 5111 EmitCompareAndBranch(instr, condition, x0, 0);
5112 } 5112 }
5113 5113
5114 5114
5115 void LCodeGen::DoSubI(LSubI* instr) { 5115 void LCodeGen::DoSubI(LSubI* instr) {
5116 bool can_overflow = instr->hydrogen()->CheckFlag(HValue::kCanOverflow); 5116 bool can_overflow = instr->hydrogen()->CheckFlag(HValue::kCanOverflow);
5117 Register result = ToRegister32(instr->result()); 5117 Register result = ToRegister32(instr->result());
5118 Register left = ToRegister32(instr->left()); 5118 Register left = ToRegister32(instr->left());
5119 Operand right = ToOperand32I(instr->right()); 5119 Operand right = ToOperand32I(instr->right());
5120 if (can_overflow) { 5120 if (can_overflow) {
5121 __ Subs(result, left, right); 5121 __ Subs(result, left, right);
(...skipping 438 matching lines...) Expand 10 before | Expand all | Expand 10 after
5560 __ Bind(&out_of_object); 5560 __ Bind(&out_of_object);
5561 __ Ldr(result, FieldMemOperand(object, JSObject::kPropertiesOffset)); 5561 __ Ldr(result, FieldMemOperand(object, JSObject::kPropertiesOffset));
5562 // Index is equal to negated out of object property index plus 1. 5562 // Index is equal to negated out of object property index plus 1.
5563 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2)); 5563 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2));
5564 __ Ldr(result, FieldMemOperand(result, 5564 __ Ldr(result, FieldMemOperand(result,
5565 FixedArray::kHeaderSize - kPointerSize)); 5565 FixedArray::kHeaderSize - kPointerSize));
5566 __ Bind(&done); 5566 __ Bind(&done);
5567 } 5567 }
5568 5568
5569 } } // namespace v8::internal 5569 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698