Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: chrome/browser/dom_ui/tips_handler.h

Issue 149083: Validates links which are to be passed on to the NTP by ensuring that they st... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/dom_ui/tips_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/tips_handler.h
===================================================================
--- chrome/browser/dom_ui/tips_handler.h (revision 19306)
+++ chrome/browser/dom_ui/tips_handler.h (working copy)
@@ -11,10 +11,6 @@
// "tip_cache": {
// "0": {
-// "index": should become time field (or not)
-// "snippet": the text of the item
-// "source": text describing source (i.e., "New York Post")
-// "thumbnail": URL of thumbnail on popgadget server
// "title": text giving title of item
// "url": link to item's page
// },
@@ -43,6 +39,9 @@
static void RegisterUserPrefs(PrefService* prefs);
private:
+ // Make sure the string we are pushing to the NTP is a valid URL.
+ bool IsValidURL(const std::wstring& url_string);
+
// So we can push data out to the page that has called this handler.
DOMUI* dom_ui_;
« no previous file with comments | « no previous file | chrome/browser/dom_ui/tips_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698