Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 14908004: add weakcallback without persistent copying (Closed)

Created:
7 years, 7 months ago by dcarney
Modified:
7 years, 7 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

add weakcallback without persistent copying R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14566

Patch Set 1 #

Patch Set 2 : missed some instances #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -153 lines) Patch
M include/v8.h View 4 chunks +39 lines, -8 lines 0 comments Download
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/d8.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/d8.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M src/global-handles.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/global-handles.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M src/runtime.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 26 chunks +91 lines, -91 lines 0 comments Download
M test/cctest/test-heap.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 5 chunks +20 lines, -20 lines 0 comments Download
M test/cctest/test-weakmaps.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
lgtm
7 years, 7 months ago (2013-05-07 07:57:10 UTC) #1
dcarney
7 years, 7 months ago (2013-05-07 10:44:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r14566 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698