Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1490783002: [bootstrapper] add checks for variable bindings in native scripts. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[bootstrapper] add checks for variable bindings in native scripts. Native scripts must not accidentally pollute the global object. R=bmeurer@chromium.org Committed: https://crrev.com/3a4846d2bd45f40a1e4e4b9fd231a3fad78ae303 Cr-Commit-Position: refs/heads/master@{#32469}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -16 lines) Patch
M src/ast/scopes.cc View 2 chunks +19 lines, -7 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/d8.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/js/date.js View 1 chunk +0 lines, -6 lines 0 comments Download
M src/parsing/parser.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
5 years ago (2015-12-01 13:25:40 UTC) #1
Benedikt Meurer
LGTM
5 years ago (2015-12-01 13:49:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490783002/1
5 years ago (2015-12-01 13:50:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 14:28:04 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-01 14:28:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a4846d2bd45f40a1e4e4b9fd231a3fad78ae303
Cr-Commit-Position: refs/heads/master@{#32469}

Powered by Google App Engine
This is Rietveld 408576698