Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1490763006: Fix buffer overflow in trace_event_android.cc (Closed)

Created:
5 years ago by Xianzhu
Modified:
5 years ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix buffer overflow in trace_event_android.cc BUG=552558 TEST=TraceEventAndroidTest.WriteToATrace Committed: https://crrev.com/643cfab725fc4e56615a3d2ff7cf2eec9d86b079 Cr-Commit-Position: refs/heads/master@{#362574}

Patch Set 1 #

Patch Set 2 : Update gn #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M base/trace_event/BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download
M base/trace_event/trace_event.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M base/trace_event/trace_event_android.cc View 1 chunk +1 line, -1 line 0 comments Download
A base/trace_event/trace_event_android_unittest.cc View 1 2 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Xianzhu
Sorry for the stupid error. I thought we had test coverage of this. Added a ...
5 years ago (2015-12-01 22:16:21 UTC) #2
Primiano Tucci (use gerrit)
Ahh LGTM, missed that in the review. https://codereview.chromium.org/1490763006/diff/20001/base/trace_event/trace_event_android_unittest.cc File base/trace_event/trace_event_android_unittest.cc (right): https://codereview.chromium.org/1490763006/diff/20001/base/trace_event/trace_event_android_unittest.cc#newcode12 base/trace_event/trace_event_android_unittest.cc:12: TEST(TraceEventAndroidTest, Smoke) ...
5 years ago (2015-12-01 23:02:38 UTC) #3
Xianzhu
https://codereview.chromium.org/1490763006/diff/20001/base/trace_event/trace_event_android_unittest.cc File base/trace_event/trace_event_android_unittest.cc (right): https://codereview.chromium.org/1490763006/diff/20001/base/trace_event/trace_event_android_unittest.cc#newcode12 base/trace_event/trace_event_android_unittest.cc:12: TEST(TraceEventAndroidTest, Smoke) { On 2015/12/01 23:02:38, Primiano Tucci wrote: ...
5 years ago (2015-12-01 23:07:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490763006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490763006/40001
5 years ago (2015-12-01 23:13:53 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-02 01:42:57 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-02 01:43:41 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/643cfab725fc4e56615a3d2ff7cf2eec9d86b079
Cr-Commit-Position: refs/heads/master@{#362574}

Powered by Google App Engine
This is Rietveld 408576698