Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1490753003: Revert of [heap] Cleanup mark bit usage. (Closed)

Created:
5 years ago by Hannes Payer (out of office)
Modified:
5 years ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Cleanup mark bit usage. (patchset #1 id:1 of https://codereview.chromium.org/1474203003/ ) Reason for revert: Still investigating bad canary. Original issue's description: > [heap] Cleanup mark bit usage. > > BUG= > > Committed: https://crrev.com/5874ac783ff9bc4bb4b2fda81f5077f06619f96c > Cr-Commit-Position: refs/heads/master@{#32362} TBR=mlippautz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/d3faef8658598e68331208b5a1846ac1c250cb49 Cr-Commit-Position: refs/heads/master@{#32461}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M src/heap/mark-compact.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/heap/spaces.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Hannes Payer (out of office)
Created Revert of [heap] Cleanup mark bit usage.
5 years ago (2015-12-01 13:28:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490753003/1
5 years ago (2015-12-01 13:28:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 13:29:34 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d3faef8658598e68331208b5a1846ac1c250cb49 Cr-Commit-Position: refs/heads/master@{#32461}
5 years ago (2015-12-01 13:29:53 UTC) #5
Hannes Payer (out of office)
5 years ago (2015-12-02 11:03:22 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1488393003/ by hpayer@chromium.org.

The reason for reverting is: Reland after fixing the potential root cause of the
canary crasher..

Powered by Google App Engine
This is Rietveld 408576698