Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 149073008: Win8 baselines for displacement GM (razzin' frazzin' --keep-going-on-failure). (Closed)

Created:
6 years, 10 months ago by Stephen White
Modified:
6 years, 10 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Win8 baselines for displacement GM (razzin' frazzin' --keep-going-on-failure). TBR=epoger BUG=skia: Committed: https://code.google.com/p/skia/source/detail?r=13232

Patch Set 1 #

Messages

Total messages: 4 (0 generated)
Stephen White
Committed patchset #1 manually as r13232 (presubmit successful).
6 years, 10 months ago (2014-01-29 22:28:31 UTC) #1
epoger
LGTM So, are you still using rebaseline.py to do these? Is there something particular you ...
6 years, 10 months ago (2014-01-30 13:53:23 UTC) #2
Stephen White
On 2014/01/30 13:53:23, epoger wrote: > LGTM > > So, are you still using rebaseline.py ...
6 years, 10 months ago (2014-01-30 15:14:40 UTC) #3
epoger
6 years, 10 months ago (2014-02-03 15:16:38 UTC) #4
Message was sent while issue was closed.
On 2014/01/30 15:14:40, Stephen White wrote:
> On 2014/01/30 13:53:23, epoger wrote:
> > LGTM
> > 
> > So, are you still using rebaseline.py to do these?  Is there something
> > particular you would like to see improved in rebaseline_server to use it
> > instead?
> 
> I find rebaseline.py gives me a bit more control, but that's probably just
> because
> I don't know what I'm doing with rebaseline_server. Maybe my next round I'll
> force
> myself to learn.

Thanks for the info, even that tidbit is helpful.  I really believe
rebaseline_server is better than rebaseline.py, so I really want to kill
rebaseline.py... so any particular pain points you can tell me about will be
helpful.

Maybe it would help for me to walk you through using rebaseline_server next
time... just let me know.

Powered by Google App Engine
This is Rietveld 408576698