Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 149073006: Explicit destruction order in gcm_unit_tests (Closed)

Created:
6 years, 10 months ago by scottmg
Modified:
6 years, 10 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews
Visibility:
Public.

Description

Explicit destruction order in gcm_unit_tests I looked through the cs.chromium.org results for codedoutputstream -file:.pb.cc -file:.java -file:.pb.h but don't see any other instances of this exact problem in non-test code (and in fact, some with similar looking constructs: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/protobuf/src/google/protobuf/io/coded_stream_unittest.cc&l=320 ) R=zea@chromium.org BUG=338962 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247815

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M google_apis/gcm/engine/connection_handler_impl_unittest.cc View 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
6 years, 10 months ago (2014-01-29 19:15:14 UTC) #1
Nicolas Zea
lgtm
6 years, 10 months ago (2014-01-29 23:05:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/149073006/1
6 years, 10 months ago (2014-01-29 23:14:39 UTC) #3
scottmg
Committed patchset #1 manually as r247815 (presubmit successful).
6 years, 10 months ago (2014-01-30 03:34:52 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 03:37:46 UTC) #5
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698